Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTSegmentCand: Fix ambiguous-reversed-operator warning by using const operator #45491

Merged
merged 1 commit into from
Jul 18, 2024
Merged

DTSegmentCand: Fix ambiguous-reversed-operator warning by using const operator #45491

merged 1 commit into from
Jul 18, 2024

Conversation

smuzaffar
Copy link
Contributor

This fixes CLANG IB warnings [a]. As compilers suggested the PR makes the operator method const

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_CLANG_X_2024-07-16-2300/RecoLocalMuon/DTSegment

  src/RecoLocalMuon/DTSegment/src/DTCombinatorialPatternReco.cc:411:18: warning: ISO C++20 considers use of overloaded operator '==' (with operand types 'DTSegmentCand' and 'DTSegmentCand') to be ambiguous despite there being a unique best viable function [-Wambiguous-reversed-operator]
   411 |     if (*(*cand) == *seg)
      |         ~~~~~~~~ ^  ~~~~
src/RecoLocalMuon/DTSegment/src/DTSegmentCand.h:70:16: note: ambiguity is between a regular call to this operator and a call with the argument order reversed
   70 |   virtual bool operator==(const DTSegmentCand& seg);
      |                ^
src/RecoLocalMuon/DTSegment/src/DTSegmentCand.h:70:16: note: mark 'operator==' as const or add a matching 'operator!=' to resolve the ambiguity

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Jul 18, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45491/40960

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • RecoLocalMuon/DTSegment (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@abbiendi, @battibass, @bellan, @jhgoh, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ac3f0/40468/summary.html
COMMIT: 7a9b44f
CMSSW: CMSSW_14_1_X_2024-07-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45491/40468/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 249 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345208
  • DQMHistoTests: Total failures: 2766
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342422
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ac3f0/40467/summary.html
COMMIT: 7a9b44f
CMSSW: CMSSW_14_1_CLANG_X_2024-07-17-1700/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45491/40467/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 13790 lines to the logs
  • Reco comparison results: 36756 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345208
  • DQMHistoTests: Total failures: 35224
  • DQMHistoTests: Total nulls: 120
  • DQMHistoTests: Total successes: 3309844
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.05 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.043 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.043 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 7 / 46 workflows

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4be3c51 into cms-sw:master Jul 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@smuzaffar @cmsbuild @jfernan2 @rappoccio